| 1234567891011121314151617181920212223242526272829303132333435363738394041424344454647 |
- from astroid import nodes
- from pylint.checkers import BaseChecker
- from pylint.checkers.utils import check_messages
- from pylint.interfaces import IAstroidChecker
- from pylint.lint import PyLinter
- class SetMembershipChecker(BaseChecker):
- __implements__ = (IAstroidChecker,)
- name = "set_membership"
- priority = -1
- msgs = {
- "R6201": (
- "Consider using set for membership test",
- "use-set-for-membership",
- "Membership tests are more efficient when performed on "
- "a lookup optimized datatype like ``sets``.",
- ),
- }
- def __init__(self, linter: PyLinter) -> None:
- """Initialize checker instance."""
- super().__init__(linter=linter)
- @check_messages("use-set-for-membership")
- def visit_compare(self, node: nodes.Compare) -> None:
- for op, comparator in node.ops:
- if op == "in":
- self._check_in_comparison(comparator)
- def _check_in_comparison(self, comparator: nodes.NodeNG) -> None:
- """Checks for membership comparisons with in-place container objects."""
- if not isinstance(comparator, nodes.BaseContainer) or isinstance(
- comparator, nodes.Set
- ):
- return
- # Heuristic - We need to be sure all items in set are hashable
- if all(isinstance(item, nodes.Const) for item in comparator.elts):
- self.add_message("use-set-for-membership", node=comparator)
- def register(linter: PyLinter) -> None:
- linter.register_checker(SetMembershipChecker(linter))
|
