1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677 |
- # Copyright (c) 2016 Alexander Todorov <atodorov@otb.bg>
- # Copyright (c) 2017-2018, 2020 Claudiu Popa <pcmanticore@gmail.com>
- # Copyright (c) 2019, 2021 Pierre Sassoulas <pierre.sassoulas@gmail.com>
- # Copyright (c) 2020 hippo91 <guillaume.peillex@gmail.com>
- # Copyright (c) 2020 Anthony Sottile <asottile@umich.edu>
- # Copyright (c) 2021 Jaehoon Hwang <jaehoonhwang@users.noreply.github.com>
- # Copyright (c) 2021 Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
- # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com>
- # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
- # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
- """Looks for comparisons to empty string."""
- import itertools
- from typing import Any, Iterable
- from astroid import nodes
- from pylint import checkers, interfaces
- from pylint.checkers import utils
- class CompareToEmptyStringChecker(checkers.BaseChecker):
- """Checks for comparisons to empty string.
- Most of the times you should use the fact that empty strings are false.
- An exception to this rule is when an empty string value is allowed in the program
- and has a different meaning than None!
- """
- __implements__ = (interfaces.IAstroidChecker,)
- # configuration section name
- name = "compare-to-empty-string"
- msgs = {
- "C1901": (
- "Avoid comparisons to empty string",
- "compare-to-empty-string",
- "Used when Pylint detects comparison to an empty string constant.",
- )
- }
- priority = -2
- options = ()
- @utils.check_messages("compare-to-empty-string")
- def visit_compare(self, node: nodes.Compare) -> None:
- _operators = ["!=", "==", "is not", "is"]
- # note: astroid.Compare has the left most operand in node.left
- # while the rest are a list of tuples in node.ops
- # the format of the tuple is ('compare operator sign', node)
- # here we squash everything into `ops` to make it easier for processing later
- ops = [("", node.left)]
- ops.extend(node.ops)
- iter_ops: Iterable[Any] = iter(ops)
- ops = list(itertools.chain(*iter_ops))
- for ops_idx in range(len(ops) - 2):
- op_1 = ops[ops_idx]
- op_2 = ops[ops_idx + 1]
- op_3 = ops[ops_idx + 2]
- error_detected = False
- # x ?? ""
- if utils.is_empty_str_literal(op_1) and op_2 in _operators:
- error_detected = True
- # '' ?? X
- elif op_2 in _operators and utils.is_empty_str_literal(op_3):
- error_detected = True
- if error_detected:
- self.add_message("compare-to-empty-string", node=node)
- def register(linter):
- """Required method to auto register this checker."""
- linter.register_checker(CompareToEmptyStringChecker(linter))
|